gomock: Added Nil() matcher.

gomock: Added Nil() matcher.

[awreece, 2011-09-29 21:18:02]

Can I get an LGTM to push this?

[dsymonds, 2011-09-29 21:20:36]

On Thu, Sep 29, 2011 at 9:18 PM,  <awreece@gmail.com> wrote:

> Can I get an LGTM to push this?

You never sent it to me before.  ;-)

I'll take a look at this soon.

[dsymonds, 2011-09-29 21:59:03]

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers.go
File gomock/matchers.go (right):

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers.go#newcode61
gomock/matchers.go:61: switch value := reflect.ValueOf(x); value.Kind() {
Pull the ValueOf out.

v := reflect.ValueOf(x)
switch v.Kind() {
  ...
}

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go
File gomock/matchers_test.go (right):

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go#newco...
gomock/matchers_test.go:22: "os"
put this up with the "testing" import, sorted.

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go#newco...
gomock/matchers_test.go:36: []e{"", 0, make(chan bool), os.NewError("err")}},
add a new(int) to this list

[dsymonds, 2011-09-29 22:00:09]

On Thu, Sep 29, 2011 at 9:18 PM,  <awreece@gmail.com> wrote:

> Can I get an LGTM to push this?

And once I've LGTM'd it I'll submit it; you don't have access to the
repo to submit it.

[awreece, 2011-09-30 02:24:36]

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers.go
File gomock/matchers.go (right):

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers.go#newcode61
gomock/matchers.go:61: switch value := reflect.ValueOf(x); value.Kind() {
On 2011/09/29 21:59:03, dsymonds wrote:
> Pull the ValueOf out.
> 
> v := reflect.ValueOf(x)
> switch v.Kind() {
>   ...
> }

Done.

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go
File gomock/matchers_test.go (right):

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go#newco...
gomock/matchers_test.go:22: "os"
On 2011/09/29 21:59:03, dsymonds wrote:
> put this up with the "testing" import, sorted.

Done.

http://codereview.appspot.com/5057043/diff/2001/gomock/matchers_test.go#newco...
gomock/matchers_test.go:36: []e{"", 0, make(chan bool), os.NewError("err")}},
On 2011/09/29 21:59:03, dsymonds wrote:
> add a new(int) to this list

Done.

[dsymonds, 2011-09-30 02:27:02]

Just one more little thing.

http://codereview.appspot.com/5057043/diff/4003/gomock/matchers.go
File gomock/matchers.go (right):

http://codereview.appspot.com/5057043/diff/4003/gomock/matchers.go#newcode61
gomock/matchers.go:61: value := reflect.ValueOf(x)
rename 'value' to 'v'. Standard Go style is to use short variable names.

[awreece, 2011-09-30 02:30:08]

http://codereview.appspot.com/5057043/diff/4003/gomock/matchers.go
File gomock/matchers.go (right):

http://codereview.appspot.com/5057043/diff/4003/gomock/matchers.go#newcode61
gomock/matchers.go:61: value := reflect.ValueOf(x)
On 2011/09/30 02:27:07, dsymonds wrote:
> rename 'value' to 'v'. Standard Go style is to use short variable names.

Done.

[dsymonds, 2011-09-30 02:32:48]

LGTM

[dsymonds, 2011-09-30 02:33:48]

*** Submitted as http://code.google.com/p/gomock/source/detail?r=e0eec933d929
***

gomock: Added Nil() matcher.

R=dsymonds
http://codereview.appspot.com/5057043

Committer: David Symonds <dsymonds@golang.org>