http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm#newcode82 scm/output-lib.scm:82: "stem::length called but will not be used for beamed ...
12 years, 7 months ago
(2011-09-17 11:38:31 UTC)
#2
On 2011/09/17 11:38:31, Neil Puttock wrote: > http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm > File scm/output-lib.scm (right): > > http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm#newcode82 ...
12 years, 7 months ago
(2011-09-17 11:50:59 UTC)
#3
On 2011/09/17 11:38:31, Neil Puttock wrote:
> http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm
> File scm/output-lib.scm (right):
>
> http://codereview.appspot.com/5057041/diff/1/scm/output-lib.scm#newcode82
> scm/output-lib.scm:82: "stem::length called but will not be used for beamed
> stem."))))
> remove full stop/period
>
> Have you found a case where this will be triggered? If so, it still needs to
> return a sane value rather than unspecified.
No, but you're right that it should return something. I'll have it return 0.
Cheers,
MS
Issue 5057041: Prunes stem::length down to the bare minimum.
(Closed)
Created 12 years, 7 months ago by MikeSol
Modified 12 years, 7 months ago
Reviewers: Neil Puttock, pkx166h
Base URL:
Comments: 1