Terminates outside_staff_callback early if a grob is outside a slur's X-extent

Terminates outside_staff_callback early if a grob is outside a slur's X-extent

[MikeSol, 2011-09-17 08:54:52]

Hey all,

This patch fixes the programming error coming from the StrokeFinger discussion. 
Currently, none of my outstanding slur work would fix this problem.

The issue is that the offset callback is tacked onto outside-staff objects
before we know if the object falls within the span of the slur.  Thus, even
though these objects are weeded out of slur scoring in score_extra_ecompasses,
the callback function doesn't know they've been weeded out and a separate
weeding out needs to happen.  This patch does that.

I'm not sure where/when/why this behavior would have changed, but I think this
is the appropriate fix.

Cheers,
MS

[pkx166h, 2011-09-17 11:55:51]

I'm getting a lot of errors in the make check for example:


/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.log 	

@@ -11,13 +11,13 @@
 
   
   c8 cis''
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
programming error: cyclic dependency: calculation-in-progress encountered for
#'quantized-positions (Beam)
-  
-  c8 cis''
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
continuing, cross fingers
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
programming error: cyclic dependency: calculation-in-progress encountered for
#'Y-extent (Stem)
+  c8 
+     cis''
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
continuing, cross fingers
 
-  
-  c8 cis''
+  c8 
+     cis''

/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:12:2:
programming error: cyclic dependency: calculation-in-progress encountered for
#'quantized-positions (Beam)
   
--snip--

This seems to be the general error.

James

[Neil Puttock, 2011-09-17 11:58:56]

On 2011/09/17 11:55:51, J_lowe wrote:
> I'm getting a lot of errors in the make check for example:
> 
> 
> /home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.log 	
> 
> @@ -11,13 +11,13 @@
>  
>    
>    c8 cis''
>
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
> programming error: cyclic dependency: calculation-in-progress encountered for
> #'quantized-positions (Beam)
> -  
> -  c8 cis''
>
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
> continuing, cross fingers
>
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
> programming error: cyclic dependency: calculation-in-progress encountered for
> #'Y-extent (Stem)
> +  c8 
> +     cis''
>
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
> continuing, cross fingers
>  
> -  
> -  c8 cis''
> +  c8 
> +     cis''
> 
>
/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:12:2:
> programming error: cyclic dependency: calculation-in-progress encountered for
> #'quantized-positions (Beam)
>    
> --snip--
> 
> This seems to be the general error.
> 
> James

I'd hold fire on the regtest checking until Mike's applied the patch for issue
#1881 (that's where these errors come from).

Cheers,
Neil

[mike_apollinemike.com, 2011-09-17 12:00:25]

On Sep 17, 2011, at 1:55 PM, pkx166h@gmail.com wrote:

> I'm getting a lot of errors in the make check for example:
> 
> 
> /home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.log
> 	
> 
> @@ -11,13 +11,13 @@
> 
> 
>   c8 cis''
>
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
> programming error: cyclic dependency: calculation-in-progress
> encountered for #'quantized-positions (Beam)
> -
> -  c8 cis''
>
-/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:2:
> continuing, cross fingers
>
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
> programming error: cyclic dependency: calculation-in-progress
> encountered for #'Y-extent (Stem)
> +  c8
> +     cis''
>
+/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:11:5:
> continuing, cross fingers
> 
> -
> -  c8 cis''
> +  c8
> +     cis''
> 
>
/home/jlowe/lilypond-git/input/regression/spacing-correction-accidentals.ly:12:2:
> programming error: cyclic dependency: calculation-in-progress
> encountered for #'quantized-positions (Beam)
> 
> --snip--
> 
> This seems to be the general error.
> 
> James
> 
> http://codereview.appspot.com/5056041/

James,

If you git pull and rerun, it should be clean now.

Cheers,
MS

[pkx166h, 2011-09-17 12:58:38]

passes make and reg tests. James

[Neil Puttock, 2011-09-21 21:44:35]

Needs a regression test.

This might do:

\relative c'' {
  \set strokeFingerOrientations = #'(up)
  \override StrokeFinger #'avoid-slur = #'outside
  <a-\rightHandFinger #2 >16( b)
}

http://codereview.appspot.com/5056041/diff/1/lily/slur.cc
File lily/slur.cc (right):

http://codereview.appspot.com/5056041/diff/1/lily/slur.cc#newcode278
lily/slur.cc:278: contains = contains || slur_wid.contains (xext[d]);
contains |= slur_wid.contains (xext[d]);