Issue 5050046: Creates convert-ly rules for flag syntax changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5050046: Creates convert-ly rules for flag syntax changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by MikeSol

Modified:
12 years, 7 months ago

Reviewers:
pkx166h, Keith, Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Creates convert-ly rules for flag syntax changes

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updates convert-ly rules as per Keith's suggestion (issue 1921) #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	python/convertrules.py	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSol

Hey all, I think this convert-ly rule should encapsulate all changes precipitating from the flag ...

12 years, 7 months ago (2011-09-18 08:55:57 UTC) #1

Keith

12 years, 7 months ago (2011-09-27 05:08:02 UTC) #4

Looks good enough to me.

http://codereview.appspot.com/5050046/diff/1/python/convertrules.py
File python/convertrules.py (right):

http://codereview.appspot.com/5050046/diff/1/python/convertrules.py#newcode3241
python/convertrules.py:3241: str = re.sub (r"Stem\s+#'transparent\s*=\s*##t",
r"Stem #'transparent = ##t \\override Flag #'transparent = ##t", str)
This last one gets fooled by the common case
 \once\override Stem #'transparent
so maybe three separate substitutions rules, for \override \once\s*\override
\revert, or maybe a not_smart for the transparent property.

Expand All Messages | Collapse All Messages