Gets first stem-info of a kneed-beam right

Gets first stem-info of a kneed-beam right

[MikeSol, 2011-09-18 08:41:01]

Hey all,

Cleaning up my work on broken beam slopes, I found this bug in calc_stem_info. 
It is a one liner, but it has a pretty significant impact on kneed beams.  The
first stem info of all kneed beams is currently being incorrectly calculated
because it accessed the property directly instead of using Beam::is_knee.  This
fixes that problem.

I'd like to push it directly to current master, as it is a one liner, passes
regtests (it changes several files that were incorrect before), and I can't move
on with my work on the other patch until this is sorted out.  I'm gonna hold off
until I get some responses back, though, to make sure that people are cool with
this.

Cheers,
MS

[Graham Percival (old account), 2011-09-18 17:00:19]

sounds reasonable to me

[hanwenn, 2011-09-19 05:50:37]

On Sun, Sep 18, 2011 at 5:41 AM,  <mtsolo@gmail.com> wrote:

> Cleaning up my work on broken beam slopes, I found this bug in
> calc_stem_info.  It is a one liner, but it has a pretty significant
> impact on kneed beams.  The first stem info of all kneed beams is
> currently being incorrectly calculated because it accessed the property
> directly instead of using Beam::is_knee.  This fixes that problem.
>
> I'd like to push it directly to current master, as it is a one liner,
> passes regtests (it changes several files that were incorrect before),
> and I can't move on with my work on the other patch until this is sorted
> out.  I'm gonna hold off until I get some responses back, though, to
> make sure that people are cool with this.

Shouldnt this just use a callback to calc is-knee ?

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[mike_apollinemike.com, 2011-09-19 05:56:34]

On Sep 19, 2011, at 7:50 AM, Han-Wen Nienhuys wrote:

> On Sun, Sep 18, 2011 at 5:41 AM,  <mtsolo@gmail.com> wrote:
> 
>> Cleaning up my work on broken beam slopes, I found this bug in
>> calc_stem_info.  It is a one liner, but it has a pretty significant
>> impact on kneed beams.  The first stem info of all kneed beams is
>> currently being incorrectly calculated because it accessed the property
>> directly instead of using Beam::is_knee.  This fixes that problem.
>> 
>> I'd like to push it directly to current master, as it is a one liner,
>> passes regtests (it changes several files that were incorrect before),
>> and I can't move on with my work on the other patch until this is sorted
>> out.  I'm gonna hold off until I get some responses back, though, to
>> make sure that people are cool with this.
> 
> Shouldnt this just use a callback to calc is-knee ?
> 

Possible - I'm not really sure why a callback currently doesn't exist for kneed
beams.  It seems like Beam::is_knee could easily be turned into a callback.

Cheers,
MS