Issue 5040045: code review 5040045: filepath: fix Glob to return no error on nonmatching pa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5040045: code review 5040045: filepath: fix Glob to return no error on nonmatching pa...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Michael Shields

Modified:
13 years, 10 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

filepath: fix Glob to return no error on nonmatching patterns filepath.Glob is documented to return nil if no files match and an error only if the pattern is invalid. This change fixes it to work as documented and adds a regression test.

Patch Set 1 #

Patch Set 2 : diff -r 849002209017 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 849002209017 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
M	src/pkg/path/filepath/match.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/path/filepath/match_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/template/helper.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Michael Shields

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-09-17 01:14:30 UTC) #1

13 years, 10 months ago (2011-09-17 03:30:57 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ab4256049da2 ***

filepath: fix Glob to return no error on nonmatching patterns

filepath.Glob is documented to return nil if no files match
and an error only if the pattern is invalid.  This change
fixes it to work as documented and adds a regression test.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5040045

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages