Issue 5032048: Message-handling: Make the Input class use the functions in warn.cc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5032048: Message-handling: Make the Input class use the functions in warn.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Reinhold

Modified:
12 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Message-handling: Make the Input class use the functions in warn.cc This allows us to handle all warnings/error really similar in warn.cc. For example, we can then simply suppress some warnings by only checking in warn.cc. This patch makes the whole handling much more consistent, as now everything is in warn.cc

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -18 lines)			Patch
	M	lily/include/input.hh	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	lily/input.cc	View		2 chunks	+17 lines, -17 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Reinhold

12 years, 7 months ago (2011-09-18 00:13:06 UTC) #1

Please review this patch, which moves all message formatting from the Input
class to the warn.cc functions. So far, there was some duplication in those two
places.

Expand All Messages | Collapse All Messages