Issue 5027042: Fix 380: Auto-detect all cyclic references in markups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5027042: Fix 380: Auto-detect all cyclic references in markups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Reinhold

Modified:
12 years, 7 months ago

Reviewers:
pkx166h

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 380: Auto-detect all cyclic references in markups Use a hare+tortoise-like algorithm to detect cyclic references in markups. MISSING: Is there any easy way to print out the arguments to a markup function in C++?

Patch Set 1 : Rebase to master #

Total comments: 1

Patch Set 2 : Code cleanup, added another regtest #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -1 line)			Patch
A	input/regression/header-cyclic-reference.ly	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	input/regression/markup-cyclic-reference.ly	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	lily/text-interface.cc	View	1	1 chunk	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reinhold

http://codereview.appspot.com/5027042/diff/2001/lily/text-interface.cc File lily/text-interface.cc (right): http://codereview.appspot.com/5027042/diff/2001/lily/text-interface.cc#newcode114 lily/text-interface.cc:114: string argstring = "TODO"; How can I turn the ...

12 years, 7 months ago (2011-09-15 12:51:24 UTC) #1

Passes make and reg tests

Expand All Messages | Collapse All Messages