Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480)

Issue 5012043: code review 5012043: test: Add test for inheriting private method from anony... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by iant
Modified:
13 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

test: Add test for inheriting private method from anonymous field. The spec says that all methods are inherited from an anonymous field. There is no exception for non-exported methods. This is related to issue 1536.

Patch Set 1 #

Patch Set 2 : diff -r 5729b8d311d4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A test/bugs/bug367.go View 1 chunk +7 lines, -0 lines 0 comments Download
A test/bugs/bug367.dir/main.go View 1 chunk +12 lines, -0 lines 0 comments Download
A test/bugs/bug367.dir/p.go View 1 chunk +16 lines, -0 lines 0 comments Download
M test/golden.out View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-09-13 16:25:28 UTC) #1
iant
I think this is another variant of issue 1536.
13 years, 8 months ago (2011-09-13 18:21:04 UTC) #2
rsc
LGTM I agree that this should work and that it is basically issue 1536.
13 years, 8 months ago (2011-09-14 16:03:36 UTC) #3
iant
13 years, 8 months ago (2011-09-14 17:31:54 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=e37a16ddcc68 ***

test: Add test for inheriting private method from anonymous field.

The spec says that all methods are inherited from an anonymous
field.  There is no exception for non-exported methods.

This is related to issue 1536.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5012043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b