Issue 5005045: GrTArray->SkTArray & docs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5005045: GrTArray->SkTArray & docs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by bsalomon

Modified:
12 years, 7 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+464 lines, -395 lines)			Patch
M	gpu/include/GrAllocator.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/include/GrClip.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	gpu/include/GrTArray.h	View	1 chunk	+0 lines, -335 lines	0 comments	Download
M	gpu/include/GrTemplates.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	gpu/src/GrAAHairLinePathRenderer.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	gpu/src/GrBufferAllocPool.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/src/GrDrawTarget.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpu.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrInOrderDrawBuffer.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	gpu/src/GrPathRenderer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrPathRendererChain.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gyp/core.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/gpu.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	include/core/SkTArray.h	View	1 chunk	+402 lines, -0 lines	0 comments	Download
M	include/core/SkTemplates.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 3

reed1

LGTM At some point the entire code base needs to be compared with STL constructs ...

12 years, 7 months ago (2011-09-14 13:35:54 UTC) #2

Closed with r2265