Issue 4992049: code review 4992049: websocket: Fix infinite recursion in WebSockAddr String()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4992049: code review 4992049: websocket: Fix infinite recursion in WebSockAddr String() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by tarm

Modified:
13 years, 11 months ago

Reviewers:

CC:
ukai, adg, rsc, golang-dev

Visibility:
Public.

Description

websocket: Fix infinite recursion in WebSockAddr String() String() is already inherited from the embedded *url.URL

Patch Set 1 #

Patch Set 2 : diff -r 5e1053337103 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5e1053337103 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	M	src/pkg/websocket/websocket.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	src/pkg/websocket/websocket_test.go	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

tarm

Hello ukai@google.com, adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-09-10 22:16:18 UTC) #1

rsc

13 years, 11 months ago (2011-09-12 17:49:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ff39ced988f4 ***

websocket: Fix infinite recursion in WebSockAddr String()

String() is already inherited from the embedded *url.URL

R=ukai, adg, rsc
CC=golang-dev
http://codereview.appspot.com/4992049

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages