include lines in breve X-extent (issue 1814)

char box of breve glyphs is widened to include
the lines, not only notehead.  This will allow
Lily to calculate collisions with breves
correctly.  It shouldn't change how breves
are aligned in note columns.

[janek, 2011-09-06 12:18:18]

New patch set uploaded, two of Bertrand's concerns addressed (i'm not sure what
the third one means).

this replaces 4931043.

http://codereview.appspot.com/4986042/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4986042/diff/1/mf/feta-noteheads.mf#newcode217
mf/feta-noteheads.mf:217: z4 + (i * (gap + stemthick), 0),
On 2011/08/25 15:03:04, Bertrand Bordage wrote:
> Hmmm... Don't you think (i * (gap + stemthick), 0)
> has to be written one time instead of four ?

I'm not sure what you mean.  Are you saying that i should assign (i * (gap +
stemthick), 0) to a variable in the for loop?  I.e. sth like

	for i := 0 step 1 until linecount - 1:
		foobar := (i * (gap + stemthick), 0);
		draw_gridline (z1 - foobar,
		               z2 - foobar,
		               stemthick);
		draw_gridline (z3 + foobar,
		               z4 + foobar,
		               stemthick);
	endfor;
?

[janek, 2011-09-08 22:10:39]

On 2011/09/06 12:18:18, janek wrote:
> I'm not sure what you mean.  Are you saying that i should assign (i * (gap +
> stemthick), 0) to a variable in the for loop?  I.e. sth like
> 
> 	for i := 0 step 1 until linecount - 1:
> 		foobar := (i * (gap + stemthick), 0);
> 		draw_gridline (z1 - foobar,
> 		               z2 - foobar,
> 		               stemthick);
> 		draw_gridline (z3 + foobar,
> 		               z4 + foobar,
> 		               stemthick);
> 	endfor;
> ?

Bertrand confirmed in other thread and patch set 2 includes this.

[pkx166h, 2011-09-12 22:54:44]

Passes make and I get a few reg test differences.

See

http://code.google.com/p/lilypond/issues/detail?id=1814#c10

for attachments,

[janek, 2011-09-12 23:07:24]

On 2011/09/12 22:54:44, J_lowe wrote:
> Passes make and I get a few reg test differences.

Thanks.  They are all expected.
Pushed as a1ce4a26eb893c1f752d260394a977ab811e3368

cheers,
Janek