changes in chord names formatting (1503, 1572)

http://code.google.com/p/lilypond/issues/detail?id=1503
http://code.google.com/p/lilypond/issues/detail?id=1572

1503 - Allow choice of prefix for chord modifiers.

This was previously "add", e.g. "Cmaj7 add6add9",
but this results in too much clutter and
is rarely used.

Issue 1503 - Allow choice of minor chord modifier.

For example, often it is preferred to use a hyphen
instead of "m". This can now be achieved via:

  \set minorChordModifier = \markup { "-" }

add chordInversionSeparator

Issue 1572 and issue 1503 - Allow choice of
chord modifier separator independently of
chord inversion separator, since conventionally
the latter is always a slash (hence the term
"slash chords"), whereas the former seldom
involves slashes.

Issue 1503 - Recognise Lydian chords


enlarge half-diminished slashed circle symbol

[janek, 2011-09-10 20:59:23]

Patches from Adam Spiers.

[janek, 2011-09-10 21:00:14]

LGTM

[Trevor Daniels, 2011-09-10 21:49:26]

LGTM AFAICT, but I am not familiar with chord notation.

Presumably there should be some doc changes?  These can either be included with
this patch or separately.  If the latter, please make a new issue for the docs
when this is pushed so we don't forget.

http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly
File ly/chord-modifiers-init.ly (right):

http://codereview.appspot.com/4981052/diff/1/ly/chord-modifiers-init.ly#newco...
ly/chord-modifiers-init.ly:30: \normal-size-super #(ly:export
(ly:wide-char->utf-8 #x00f8))
please replace tab with spaces
(I know you didn't insert it, but we want to remove tabs in the source ASAP)

http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm
File scm/chord-ignatzek-names.scm (right):

http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#new...
scm/chord-ignatzek-names.scm:175: (add-markups (map (lambda (x)
(glue-word-to-step add-pitch-prefix x))
tab

http://codereview.appspot.com/4981052/diff/1/scm/chord-ignatzek-names.scm#new...
scm/chord-ignatzek-names.scm:189: (list invsep (name-note bass-pitch #f))
tabs

[pkx166h, 2011-09-11 07:16:25]

Passes make test but fails reg test check.

See:

http://code.google.com/p/lilypond/issues/detail?id=1572#c7

for more information

James

[adam.spiers, 2011-11-01 16:40:47]

I have finally figured out how to reproduce these regressions,
and am working on a fix.

[adam.spiers, 2011-11-02 17:58:51]

I think I am now finished.  The new patch series is available at

    https://github.com/aspiers/lilypond/commits/jazz

IMHO there are now too many patches in the series to combine into a single
commit for review.  To do so would lose a lot of clarity in the git history.  So
I am not sure how this review process should proceed.

Anyhow, you can fetch the patches via:

    git remote add aspiers git://github.com/aspiers/lilypond.git
    git fetch aspiers jazz

The patches also adjust the regression tests and English documentation to be
consistent with changes to the code.  Translation work is required for other
languages.

[adam.spiers, 2011-11-06 15:52:15]

I've done a corresponding patch for changes.tely but I don't have permissions to
upload it to this issue so you'll have to get it from here: 

https://github.com/aspiers/lilypond/commit/3f02826bf5e8854f7da06b2f822d3a65cf...

[Graham Percival, 2011-11-07 00:15:48]

On Sun, Nov 06, 2011 at 03:52:15PM +0000, adam.spiers@gmail.com wrote:
> I've done a corresponding patch for changes.tely but I don't have
> permissions to upload it to this issue

that's because Janek uploaded the original issue.  Could you just
make a new one?  just ignore the old codereview issue.

Uploading a new patch with git-cl, and associate it with issue
tracker 1503 or 1572.

- Graham

[adam.spiers, 2011-11-07 11:13:09]

On 2011/11/07 00:15:48, Graham Percival wrote:
> On Sun, Nov 06, 2011 at 03:52:15PM +0000, mailto:adam.spiers@gmail.com wrote:
> > I've done a corresponding patch for changes.tely but I don't have
> > permissions to upload it to this issue
> 
> that's because Janek uploaded the original issue.  Could you just
> make a new one?  just ignore the old codereview issue.
> 
> Uploading a new patch with git-cl, and associate it with issue
> tracker 1503 or 1572.
> 
> - Graham

Whoops, I forgot that Carl already created a separate issue for the new version
of this patch series:

http://codereview.appspot.com/5320074

So this one (4981052) should be ignored entirely now, and closed/deleted when
Janek gets back.