code review 4975057: leveldb: initial check-in of the db and memdb packages.

leveldb: initial check-in of the db and memdb packages.

memdb is an in-memory implementation of the db interface.
A future changeset will provide an on-disk implementation.

[nigeltao, 2011-09-05 10:50:02]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/leveldb-go/

[nigeltao, 2011-09-05 10:52:25]

On 5 September 2011 20:50,  <nigeltao@golang.org> wrote:
> Description:
> leveldb: initial check-in of the db and memdb packages.
>
> Please review this at http://codereview.appspot.com/4975057/

Note that this is part of the http://code.google.com/p/leveldb-go/
repository, not the standard package library.

[bradfitz, 2011-09-05 19:28:01]

LGTM

http://codereview.appspot.com/4975057/diff/4001/leveldb/db/db.go
File leveldb/db/db.go (right):

http://codereview.appspot.com/4975057/diff/4001/leveldb/db/db.go#newcode68
leveldb/db/db.go:68: // Close closes the iterator and returns any accumulated
error. Exhausting
it is calling Close multiple times defined?

http://codereview.appspot.com/4975057/diff/4001/leveldb/db/options.go
File leveldb/db/options.go (right):

http://codereview.appspot.com/4975057/diff/4001/leveldb/db/options.go#newcode21
leveldb/db/options.go:21: func (o *Options) GetComparer() Comparer {
I wonder if there's a different name that doesn't encourage the "Get" prefix
style.  ComparerOrDefault, perhaps, but it's a bit long.

*shrug*

http://codereview.appspot.com/4975057/diff/4001/leveldb/memdb/memdb.go
File leveldb/memdb/memdb.go (right):

http://codereview.appspot.com/4975057/diff/4001/leveldb/memdb/memdb.go#newcod...
leveldb/memdb/memdb.go:211: return len(m.data)
s/len/cap/ perhaps. it's approximate, though.

[nigeltao, 2011-09-06 10:34:09]

*** Submitted as 5d54f673ba6a ***

leveldb: initial check-in of the db and memdb packages.

memdb is an in-memory implementation of the db interface.
A future changeset will provide an on-disk implementation.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4975057