Added LateParsed property to attributes in TableGen code.

[supertri, 2011-09-01 18:35:41]

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp
File utils/TableGen/ClangAttrEmitter.cpp (right):

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:774: std::vector<StringRef> Spellings =
getValueAsListOfStrings(Attr, "Spellings");
Over 80 characters.

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:776: for
(std::vector<StringRef>::const_iterator I = Spellings.begin(),
SmallVector instead of vector?

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:779: OS << ".Case(\"" << Spelling << "\", "
<< LateParsed << ")\n";
Why a temp Spelling instead of *I?

[delesley, 2011-09-01 20:26:08]

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter.cpp
File utils/TableGen/ClangAttrEmitter.cpp (right):

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:774: std::vector<StringRef> Spellings =
getValueAsListOfStrings(Attr, "Spellings");
On 2011/09/01 18:35:41, supertri wrote:
> Over 80 characters.

Done.

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:776: for
(std::vector<StringRef>::const_iterator I = Spellings.begin(),
On 2011/09/01 18:35:41, supertri wrote:
> SmallVector instead of vector?

The API call specifies a std::vector.

http://codereview.appspot.com/4975048/diff/1/utils/TableGen/ClangAttrEmitter....
utils/TableGen/ClangAttrEmitter.cpp:779: OS << ".Case(\"" << Spelling << "\", "
<< LateParsed << ")\n";
On 2011/09/01 18:35:41, supertri wrote:
> Why a temp Spelling instead of *I?

Done.

[chandlerc, 2011-09-01 22:11:10]

http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
File utils/TableGen/ClangAttrEmitter.h (right):

http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
utils/TableGen/ClangAttrEmitter.h:107: {}
For reasons that baffle me, all of the previous entries here line up the { with
the : on the previous line... might as well be consistent.

[delesley, 2011-09-02 18:23:40]

http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
File utils/TableGen/ClangAttrEmitter.h (right):

http://codereview.appspot.com/4975048/diff/4001/utils/TableGen/ClangAttrEmitt...
utils/TableGen/ClangAttrEmitter.h:107: {}
On 2011/09/01 22:11:10, chandlerc wrote:
> For reasons that baffle me, all of the previous entries here line up the {
with
> the : on the previous line... might as well be consistent.

Done.