exp/wingui: changed to be compatible with windows/amd64

exp/wingui: made compatible with windows/amd64

[jp, 2011-08-26 10:05:46]

weakly related files moved from http://codereview.appspot.com/4958042

[brainman, 2011-08-29 02:23:36]

http://codereview.appspot.com/4974041/diff/1001/src/pkg/syscall/zsyscall_wind...
File src/pkg/syscall/zsyscall_windows_386.go (left):

http://codereview.appspot.com/4974041/diff/1001/src/pkg/syscall/zsyscall_wind...
src/pkg/syscall/zsyscall_windows_386.go:144: func GetProcAddress(module Handle,
procname string) (proc Handle, errno int) {
There are some files missing from this CL. This file is auto generated from
syscall_windows*.

[jp, 2011-08-29 02:38:47]

On 2011/08/29 02:23:36, brainman wrote:
>
http://codereview.appspot.com/4974041/diff/1001/src/pkg/syscall/zsyscall_wind...
> File src/pkg/syscall/zsyscall_windows_386.go (left):
> 
>
http://codereview.appspot.com/4974041/diff/1001/src/pkg/syscall/zsyscall_wind...
> src/pkg/syscall/zsyscall_windows_386.go:144: func GetProcAddress(module
Handle,
> procname string) (proc Handle, errno int) {
> There are some files missing from this CL. This file is auto generated from
> syscall_windows*.

fixed

[brainman, 2011-08-31 00:49:56]

http://codereview.appspot.com/4974041/diff/8001/src/pkg/exp/wingui/zwinapi.go
File src/pkg/exp/wingui/zwinapi.go (right):

http://codereview.appspot.com/4974041/diff/8001/src/pkg/exp/wingui/zwinapi.go...
src/pkg/exp/wingui/zwinapi.go:31: func GetModuleHandle(modname *uint16) (handle
syscall.Handle, errno int) {
You should be able to recreate this file automatically:

# rm zwinapi.go; make clean all
rm -rf *.o *.a *.[568vq] [568vq].out wingui.exe _test _testmain.go test.out
build.out
/root/hg/go/src/pkg/syscall/mksyscall_windows.pl winapi.go \
                | sed 's/^package.*syscall$/package main/' \
                | sed '/^import/a \
                        import "syscall"' \
                | sed 's/Syscall/syscall.Syscall/' \
                | sed 's/NewLazyDLL/syscall.NewLazyDLL/' \
                | sed 's/EINVAL/syscall.EINVAL/' \
                | gofmt \
                > zwinapi.go
8g  -o _go_.8 gui.go winapi.go zwinapi.go
gui.go:41: cannot use hwnd (type syscall.Handle) as type uint32 in function
argument
gui.go:41: cannot use mh (type syscall.Handle) as type uint32 in function
argument
gui.go:44: cannot assign uint32 to bh (type syscall.Handle) in multiple
assignment
gui.go:49: cannot use hwnd (type syscall.Handle) as type uint32 in function
argument
gui.go:49: cannot use wparam (type uintptr) as type int32 in function argument
gui.go:49: cannot use lparam (type uintptr) as type int32 in function argument
gui.go:49: cannot use DefWindowProc(hwnd, msg, wparam, lparam) (type int32) as
type uintptr in assignment
gui.go:53: cannot use hwnd (type syscall.Handle) as type uint32 in function
argument
gui.go:58: cannot use hwnd (type syscall.Handle) as type uint32 in function
argument
gui.go:58: cannot use wparam (type uintptr) as type int32 in function argument
gui.go:58: too many errors
make: *** [_go_.8] Error 1

http://codereview.appspot.com/4974041/diff/8001/src/pkg/syscall/syscall_windo...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4974041/diff/8001/src/pkg/syscall/syscall_windo...
src/pkg/syscall/syscall_windows.go:161: //sys	GetProcAddress(module Handle,
procname string) (proc uintptr, errno int)
Why stop here? You should continue and change all Syscall functions too then.
And all others that use ProcAddress ...

[jp, 2011-08-31 03:40:50]

PTAL

http://codereview.appspot.com/4974041/diff/8001/src/pkg/syscall/syscall_windo...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4974041/diff/8001/src/pkg/syscall/syscall_windo...
src/pkg/syscall/syscall_windows.go:161: //sys	GetProcAddress(module Handle,
procname string) (proc uintptr, errno int)
On 2011/08/31 00:49:56, brainman wrote:
> Why stop here? You should continue and change all Syscall functions too then.
> And all others that use ProcAddress ...

This file looks 64bit ready. 
My change is minor and fixes no bugs and has no effect it the resulting binary
code (uintptr and Handle have same size).
It only adds a bit clarity: the result if GetProcAddress is not a Handle line
HANDLE or HWND but a pointer.

[brainman, 2011-08-31 05:39:32]

On 2011/08/31 03:40:50, jp wrote:
> It only adds a bit clarity: the result if GetProcAddress is not a Handle line
> HANDLE or HWND but a pointer.

My bad, I was not looking. I thought, you are changing from uintptr to Handle.

LGTM.

[brainman, 2011-08-31 05:40:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=43c67d5eb679 ***

exp/wingui: made compatible with windows/amd64

R=golang-dev, alex.brainman
CC=golang-dev, vcc.163
http://codereview.appspot.com/4974041

Committer: Alex Brainman <alex.brainman@gmail.com>