Issue 4969069: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4969069: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by Reinhold

Modified:
12 years, 7 months ago

Reviewers:
pkx166h, joeneeman, Neil Puttock, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord

Patch Set 1 : Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord #

Total comments: 3

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	A	input/regression/laissez-vibrer-chords.ly	View		1 chunk	+11 lines, -0 lines	1 comment	Download
	M	lily/laissez-vibrer-engraver.cc	View		1 chunk	+19 lines, -3 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Neil Puttock

12 years, 7 months ago (2011-09-14 19:58:40 UTC) #4

LGTM.

http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibr...
File input/regression/laissez-vibrer-chords.ly (right):

http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibr...
input/regression/laissez-vibrer-chords.ly:1: \version "2.11.31"
2.15.12

http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver.cc
File lily/laissez-vibrer-engraver.cc (right):

http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver....
lily/laissez-vibrer-engraver.cc:66: /* use the heard event_ for all noteheads,
or an individual event for just
note heads

http://codereview.appspot.com/4969069/diff/2001/lily/laissez-vibrer-engraver....
lily/laissez-vibrer-engraver.cc:67: * a single note-head (attached as an
articulation inside a chord) */
note head

Expand All Messages | Collapse All Messages