Issue 4968063: code review 4968063: exp/template/html: string replacement refactoring.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4968063: code review 4968063: exp/template/html: string replacement refactoring. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by nigeltao

Modified:
13 years, 11 months ago

Reviewers:

CC:
MikeSamuel, golang-dev

Visibility:
Public.

Description

exp/template/html: string replacement refactoring.

Patch Set 2 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r 1cd42fb11eea https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -131 lines)			Patch
	M	src/pkg/exp/template/html/js.go	View	1 2 3 4 5	2 chunks	+79 lines, -131 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-09-02 10:09:15 UTC) #1

MikeSamuel

LGTM http://codereview.appspot.com/4968063/diff/10001/src/pkg/exp/template/html/js.go File src/pkg/exp/template/html/js.go (right): http://codereview.appspot.com/4968063/diff/10001/src/pkg/exp/template/html/js.go#newcode208 src/pkg/exp/template/html/js.go:208: if repl == "" { Maybe move this ...

13 years, 11 months ago (2011-09-02 17:28:38 UTC) #2

nigeltao

13 years, 11 months ago (2011-09-03 00:30:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b42014761d96 ***

exp/template/html: string replacement refactoring.

R=mikesamuel
CC=golang-dev
http://codereview.appspot.com/4968063

Expand All Messages | Collapse All Messages