Issue 4967067: code review 4967067: time: another attempt to fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4967067: code review 4967067: time: another attempt to fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by brainman

Modified:
13 years, 11 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

time: another attempt to fix windows build

Patch Set 2 : diff -r 4beaeaead995 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4beaeaead995 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 4beaeaead995 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	src/pkg/time/zoneinfo_windows.go	View	1	2 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-09-13 02:33:08 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/4967067/diff/4001/src/pkg/time/zoneinfo_windows.go File src/pkg/time/zoneinfo_windows.go (right): http://codereview.appspot.com/4967067/diff/4001/src/pkg/time/zoneinfo_windows.go#newcode74 src/pkg/time/zoneinfo_windows.go:74: Year: z.year, I had originally converted it to ...

13 years, 11 months ago (2011-09-13 02:38:31 UTC) #2

brainman

13 years, 11 months ago (2011-09-13 02:42:31 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=902201d20e3a ***

time: another attempt to fix windows build

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4967067

Expand All Messages | Collapse All Messages