Issue 4967056: code review 4967056: template: indirect or dereference function arguments if...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4967056: code review 4967056: template: indirect or dereference function arguments if... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by r

Modified:
12 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

template: indirect or dereference function arguments if necessary to match the type of the formal. Fixes issue 2235

Patch Set 1 #

Patch Set 2 : diff -r b7badceba5ec https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	src/pkg/template/exec.go	View		1 chunk	+12 lines, -1 line	0 comments	Download
	M	src/pkg/template/exec_test.go	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2011-09-06 22:17:12 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=a163a464ef59 *** template: indirect or dereference function arguments if necessary to match ...

12 years, 7 months ago (2011-09-06 22:34:43 UTC) #3

rsc

12 years, 7 months ago (2011-09-06 22:40:31 UTC) #4

you can avoid a call to value.Elem() by using
    value.Type().Elem().AssignableTo(typ)
instead of
    value.Elem().Type().AssignableTo(typ)

Expand All Messages | Collapse All Messages