Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 4965058: code review 4965058: runtime: add test for multiple concurrent channel consumers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by cw
Modified:
13 years, 11 months ago
Reviewers:
CC:
rsc, dvyukov, golang-dev
Visibility:
Public.

Description

runtime: add test for multiple concurrent channel consumers There was a time (in the past) when this wasn't robust.

Patch Set 1 #

Patch Set 2 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r c581abafc917 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c581abafc917 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 7 : diff -r 1d40e9b94b91 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/pkg/runtime/chan_test.go View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 15
cw
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-09-01 04:45:22 UTC) #1
dvyukov
http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go#newcode75 src/pkg/runtime/chan_test.go:75: p := 0 What 'p' is for? http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go#newcode78 src/pkg/runtime/chan_test.go:78: ...
13 years, 11 months ago (2011-09-01 06:56:52 UTC) #2
rsc
http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go#newcode65 src/pkg/runtime/chan_test.go:65: const niter = 14121 // keep below 16-bits I'm ...
13 years, 11 months ago (2011-09-01 19:26:06 UTC) #3
dvyukov
http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go#newcode65 src/pkg/runtime/chan_test.go:65: const niter = 14121 // keep below 16-bits On ...
13 years, 11 months ago (2011-09-01 20:32:37 UTC) #4
rsc
>> I'm afraid to ask, but why? > > I guess to not overflow expect ...
13 years, 11 months ago (2011-09-01 20:34:27 UTC) #5
cw
On Thu, Sep 01, 2011 at 06:56:52AM +0000, dvyukov@google.com wrote: > http://codereview.appspot.com/4965058/diff/5001/src/pkg/runtime/chan_test.go#newcode75 > src/pkg/runtime/chan_test.go:75: p ...
13 years, 11 months ago (2011-09-01 21:09:14 UTC) #6
cw
> >I'm afraid to ask, but why? > > I guess to not overflow expect ...
13 years, 11 months ago (2011-09-01 21:09:32 UTC) #7
cw
Hello rsc@golang.org, dvyukov@google.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2011-09-02 01:29:09 UTC) #8
dvyukov
http://codereview.appspot.com/4965058/diff/5002/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): http://codereview.appspot.com/4965058/diff/5002/src/pkg/runtime/chan_test.go#newcode78 src/pkg/runtime/chan_test.go:78: if pn[w%len(pn)] == v { Don't you mean something ...
13 years, 11 months ago (2011-09-02 05:57:24 UTC) #9
cw
On Fri, Sep 02, 2011 at 05:57:24AM +0000, dvyukov@google.com wrote: > Don't you mean something ...
13 years, 11 months ago (2011-09-02 06:10:26 UTC) #10
dvyukov
http://codereview.appspot.com/4965058/diff/10002/src/pkg/runtime/chan_test.go File src/pkg/runtime/chan_test.go (right): http://codereview.appspot.com/4965058/diff/10002/src/pkg/runtime/chan_test.go#newcode92 src/pkg/runtime/chan_test.go:92: q <- pn[n] I would suggest to remove n ...
13 years, 11 months ago (2011-09-02 06:23:43 UTC) #11
cw
> I would suggest to remove n and use just: > v := pn[i%len(pn)] > ...
13 years, 11 months ago (2011-09-02 06:27:50 UTC) #12
dvyukov
LGTM
13 years, 11 months ago (2011-09-02 07:07:24 UTC) #13
rsc
LGTM
13 years, 11 months ago (2011-09-05 11:36:21 UTC) #14
rsc
13 years, 11 months ago (2011-09-05 11:40:57 UTC) #15
*** Submitted as http://code.google.com/p/go/source/detail?r=cd4860b578b3 ***

runtime: add test for multiple concurrent channel consumers

There was a time (in the past) when this wasn't robust.

R=rsc, dvyukov
CC=golang-dev
http://codereview.appspot.com/4965058

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b