code review 4965050: doc/progs: fixed for windows/amd64

doc/progs: fixed for windows/amd64
doc/progs has been preventing windows/amd64 to be successfully compiled

[jp, 2011-08-26 10:06:05]

weakly related files moved from http://codereview.appspot.com/4958042

[rsc, 2011-08-26 19:50:11]

http://codereview.appspot.com/4965050/diff/2001/doc/progs/helloworld3.go
File doc/progs/helloworld3.go (left):

http://codereview.appspot.com/4965050/diff/2001/doc/progs/helloworld3.go#oldc...
doc/progs/helloworld3.go:17: if f == nil {
You changed this line.  Please change it back.
If Windows's file.Open is returning a non-nil f on error,
that's something we need to fix. 

If this was just a cleanup, then I agree it might be
worth doing, but it's unrelated to getting Windows
working.  I'd rather get Windows working in this CL
and leave cosmetic changes like this one (which
will require updating ../go_tutorial.html) for review
by Rob.  Thanks.

http://codereview.appspot.com/4965050/diff/2001/doc/progs/run
File doc/progs/run (right):

http://codereview.appspot.com/4965050/diff/2001/doc/progs/run#newcode18
doc/progs/run:18: if [ "$GOARCH" = "amd64" ];then
delete this
$GC -o file.$O file_windows.go

http://codereview.appspot.com/4965050/diff/2001/doc/progs/run#newcode69
doc/progs/run:69: if [ "$GOOS" = "windows" ];then
I'd rather write something that will work everywhere.
Maybe just

testit helloworld3 "" "hello, world can't open file; err="

I'd like to get the error message fixed but that has been
a long time problem.

[jp, 2011-08-26 20:58:10]

http://codereview.appspot.com/4965050/diff/2001/doc/progs/helloworld3.go
File doc/progs/helloworld3.go (left):

http://codereview.appspot.com/4965050/diff/2001/doc/progs/helloworld3.go#oldc...
doc/progs/helloworld3.go:17: if f == nil {
On 2011/08/26 19:50:11, rsc wrote:
> You changed this line.  Please change it back.
> If Windows's file.Open is returning a non-nil f on error,
> that's something we need to fix. 

Seems we have to fix it here:
http://codereview.appspot.com/4965050/diff2/2001:7001/doc/progs/file_windows.go
There was a comparision "fd < 0".
But fd is unsigned, so file.Open never returned nil

[rsc, 2011-08-26 21:04:35]

I think this boils down to a one-line CL: s/8/$O/

http://codereview.appspot.com/4965050/diff/7001/doc/progs/helloworld3.go
File doc/progs/helloworld3.go (right):

http://codereview.appspot.com/4965050/diff/7001/doc/progs/helloworld3.go#newc...
doc/progs/helloworld3.go:16: f, _ := file.Open("/does/not/exist")
Please revert all changes to this file.
Any changes here have to be reflected in the 
actual tutorial and I don't want to do that.

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run
File doc/progs/run (right):

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run#newcode65
doc/progs/run:65: testit helloworld3 "" "hello, world can't open file; err="
Sorry, I thought this argument was a substring search.
Please revert this line's change too.
The test will still pass during the build, it just prints the error.

[jp, 2011-08-26 22:13:58]

On 2011/08/26 21:04:35, rsc wrote:
> Please revert this line's change too.
> The test will still pass during the build, it just prints the error.

done

[rsc, 2011-08-29 13:02:37]

>> Please revert this line's change too.
>> The test will still pass during the build, it just prints the error.
>
> done

does not appear to be uploaded.
please run hg mail

[jp, 2011-08-29 18:43:29]

Hello rsc@golang.org (cc: alex.brainman@gmail.com, golang-dev@googlegroups.com,
vcc.163@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-08-29 18:54:41]

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run
File doc/progs/run (right):

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run#newcode65
doc/progs/run:65: testit helloworld3 "" "hello, world can't open file; err="
On 2011/08/26 21:04:35, rsc wrote:
> Sorry, I thought this argument was a substring search.
> Please revert this line's change too.
> The test will still pass during the build, it just prints the error.

You missed this comment.

[jp, 2011-08-29 19:19:34]

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run
File doc/progs/run (right):

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run#newcode65
doc/progs/run:65: testit helloworld3 "" "hello, world can't open file; err="
On 2011/08/29 18:54:41, rsc wrote:
> On 2011/08/26 21:04:35, rsc wrote:
> > Sorry, I thought this argument was a substring search.
> > Please revert this line's change too.
> > The test will still pass during the build, it just prints the error.
> 
> You missed this comment.

You comment on patch revision which is 3 days old.
Are Patch Set 4 and 5 visible to you ?
http://codereview.appspot.com/4965050/patch/13001/12003

[rsc, 2011-08-29 19:25:15]

Sorry for the confusion.

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run
File doc/progs/run (right):

http://codereview.appspot.com/4965050/diff/7001/doc/progs/run#newcode65
doc/progs/run:65: testit helloworld3 "" "hello, world can't open file; err="
On 2011/08/29 19:19:34, jp wrote:
> On 2011/08/29 18:54:41, rsc wrote:
> > On 2011/08/26 21:04:35, rsc wrote:
> > > Sorry, I thought this argument was a substring search.
> > > Please revert this line's change too.
> > > The test will still pass during the build, it just prints the error.
> > 
> > You missed this comment.
> 
> You comment on patch revision which is 3 days old.
> Are Patch Set 4 and 5 visible to you ?
> http://codereview.appspot.com/4965050/patch/13001/12003

Yes, they are.  I was commenting here because
that's where my comment was.  But now I see what
happened.  I didn't mean to revert to the old patch set 1
code.  I meant to revert to the repository code.
Make it so this section is not being changed
by this CL at all.

[jp, 2011-08-29 19:29:46]

Hello rsc@golang.org (cc: alex.brainman@gmail.com, golang-dev@googlegroups.com,
vcc.163@gmail.com),

Please take another look.

[rsc, 2011-08-29 19:37:09]

LGTM

[rsc, 2011-08-29 19:38:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=73c091a3fc96 ***

doc/progs: fix windows/amd64

R=rsc
CC=alex.brainman, golang-dev, vcc.163
http://codereview.appspot.com/4965050

Committer: Russ Cox <rsc@golang.org>