code review 4965048: bytes.Buffer: clarify that NewBuffer is not for beginners

bytes.Buffer: clarify that NewBuffer is not for beginners

[r, 2011-08-26 00:24:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-26 00:27:46]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-08-26 00:28:11]

http://codereview.appspot.com/4965048/diff/1/src/pkg/bytes/buffer.go
File src/pkg/bytes/buffer.go (right):

http://codereview.appspot.com/4965048/diff/1/src/pkg/bytes/buffer.go#newcode340
src/pkg/bytes/buffer.go:340: // buf should have the desired capacity but a
length of zero. Unless it is
Start a new paragraph at "Unless".

Maybe it should be worded more like "In most cases, using new(Buffer) (or just
declaring a Buffer variable) is preferable to NewBuffer. In particular..."

[r, 2011-08-26 02:47:40]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-08-26 03:10:00]

LGTM

[r, 2011-08-26 05:09:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=5f83cfd42365 ***

bytes.Buffer: clarify that NewBuffer is not for beginners

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4965048