code review 4964073: image: change the NewXxx functions to take a Rectangle ...

image: change the NewXxx functions to take a Rectangle instead of
taking (w, h int).

[nigeltao, 2011-09-09 23:42:46]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-09-09 23:45:24]

On 10 September 2011 09:42,  <nigeltao@golang.org> wrote:
> Description:
> image: change the NewXxx functions to take a Rectangle instead of
> taking (w, h int).
>
> Please review this at http://codereview.appspot.com/4964073/

BTW, I haven't used the go/ast package before, so I might have done
something wrong in the gofix change, but the new gofix test does pass,
and it did fix freetype-go for me.

[bsiegert, 2011-09-12 09:56:32]

Very nice!

LGTM from my side, although I m not competent to comment on the gofix change.

--Benny.

[rsc, 2011-09-12 17:03:31]

LGTM

But I haven't heard anything from r about the API change.
Please wait for him to sign off.

[r, 2011-09-12 18:21:10]

LGTM
the noise is unfortunate but necessary

[nigeltao, 2011-09-14 11:39:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=f0707298f4f4 ***

image: change the NewXxx functions to take a Rectangle instead of
taking (w, h int).

R=rsc, bsiegert, r
CC=golang-dev
http://codereview.appspot.com/4964073