Fixes missing images in big website page

This is an updated patch to put the missing image files back into http://lilypond.org/doc/v2.15/Documentation/web-big-page.html#examples.

It adds an extra element to the path to ly-examples (web/) which fixes up the links in web-big-page.  It does the same with the css address.  These extra elements are then parsed out with postprocess_html.py and website_post.py.  The
latter file change is the new feature of this patch - it ensures that the split web pages are valid after make website and also make doc.  I have used this patch and compiled from scratch and see both web-split and web-big have the example images and use the style sheet.

To test this.  Apply the patch.  make website - do you see images and styles in /lilypond-git/build/out-website/website/index.html.  make; make doc.  Do you see images in web-split and web-big?  If these are yes, then the patch is OK.

There is a subsidiary change - to stop website_post.py repeatedly adding a footer to the page.  I implemented this to assist testing.

PATCH 2.  This adds a relative directory address to the links to the example images, and then parses it out for the split-web page only.  On my system, applying this patch and then running make doc produces a web-big-page with all the images included.

[PhilEHolmes, 2011-08-29 10:00:34]

As requested, an updated code review.  Please review.

[Graham Percival (old account), 2011-08-29 12:58:11]

I see images, but not ly-examples.  Are you sure you see ly-examples on your
system?

[email_philholmes.net, 2011-08-29 13:00:55]

----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
Sent: Monday, August 29, 2011 1:58 PM
Subject: Re: Fixes missing images in big website page (issue 4963046)


>I see images, but not ly-examples.  Are you sure you see ly-examples on
> your system?
> 
> http://codereview.appspot.com/4963046/

Is this after make doc?

--
Phil Holmes

[Graham Percival, 2011-08-29 13:30:06]

On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote:
> ----- Original Message ----- From: <percival.music.ca@gmail.com>
> To: <PhilEHolmes@googlemail.com>
> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
> Sent: Monday, August 29, 2011 1:58 PM
> Subject: Re: Fixes missing images in big website page (issue 4963046)
> 
> 
> >I see images, but not ly-examples.  Are you sure you see ly-examples on
> >your system?
> >
> >http://codereview.appspot.com/4963046/
> 
> Is this after make doc?

Yes.  make, make doc, look in web-big-html.

Cheers,
- Graham

[email_philholmes.net, 2011-08-29 16:24:57]

----- Original Message ----- 
From: "Graham Percival" <graham@percival-music.ca>
To: "Phil Holmes" <email@philholmes.net>
Cc: <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; 
<lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
Sent: Monday, August 29, 2011 2:29 PM
Subject: Re: Fixes missing images in big website page (issue 4963046)


> On Mon, Aug 29, 2011 at 02:00:51PM +0100, Phil Holmes wrote:
>> ----- Original Message ----- From: <percival.music.ca@gmail.com>
>> To: <PhilEHolmes@googlemail.com>
>> Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
>> Sent: Monday, August 29, 2011 1:58 PM
>> Subject: Re: Fixes missing images in big website page (issue 4963046)
>>
>>
>> >I see images, but not ly-examples.  Are you sure you see ly-examples on
>> >your system?
>> >
>> >http://codereview.appspot.com/4963046/
>>
>> Is this after make doc?
>
> Yes.  make, make doc, look in web-big-html.
>
> Cheers,
> - Graham

OK.  My claim that this is fixed is partly down to the number of copies of 
web-big-page.html on the system after a build.  It's fixed in the wrong one, 
but not fixed in the right one.  To get my head fully around this, I think I 
need to be able to run lots of full make doc sessions.  I need to wait a 
couple of weeks for my new machine to be delivered.

--
Phil Holmes

[Graham Percival, 2011-08-31 05:00:29]

On Mon, Aug 29, 2011 at 05:24:51PM +0100, Phil Holmes wrote:
> OK.  My claim that this is fixed is partly down to the number of
> copies of web-big-page.html on the system after a build.  It's fixed
> in the wrong one, but not fixed in the right one.  To get my head
> fully around this, I think I need to be able to run lots of full
> make doc sessions.  I need to wait a couple of weeks for my new
> machine to be delivered.

ok.  Another option would be to sort out the locations of css/ and
pictures/, and/or add some symlinks, instead of modifying the
texinfo+html.
http://code.google.com/p/lilypond/issues/detail?id=983

But that's also something that should wait until your new
computer.  :)

Cheers,
- Graham

[PhilEHolmes, 2011-09-16 11:40:58]

Updated patch which produces a web-big-page with all images included.  Please
review.  Next step after this will be to fix the links in that page.

[Graham Percival (old account), 2011-09-21 04:08:31]

LGTM.  A quick test showed no problems in make doc.  I didn't get pictures in
make website, but then I tried make website without the patch applied, and I
still didn't get pictures... evidently I don't have my desktop set up to create
the full website any more.  So that's not a reason to distrust this patch.

[mail_philholmes.net, 2011-09-22 09:44:24]

----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>; <email@philholmes.net>; 
<graham@percival-music.ca>
Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Wednesday, September 21, 2011 5:08 AM
Subject: Re: Fixes missing images in big website page (issue 4963046)


> LGTM.  A quick test showed no problems in make doc.  I didn't get
> pictures in make website, but then I tried make website without the
> patch applied, and I still didn't get pictures... evidently I don't have
> my desktop set up to create the full website any more.  So that's not a
> reason to distrust this patch.
>
> http://codereview.appspot.com/4963046/

FWIW, running make website always produces a website with no pictures.  make 
tries to copy them but they're only created during make doc.  To get the 
images, on a normal make build, you must run make doc before make website.

--
Phil Holmes