change longas similarly to how breves were changed

change longas similarly to how breves were changed

Put vertical lines farther apart,
make them longer to increase readability
and include them in X-extent.

[janek, 2011-09-13 00:35:55]

http://code.google.com/p/lilypond/issues/detail?id=1883

[Ian Hulin (gmail), 2011-09-13 08:58:57]

Mostly LGTM, apart from one calculation you do four times.  Do it once once and
save as a variable and use that.

Cheers,
Ian

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120: 
foobar = quanted_line_length * staff_space;
% because you use 'quanted_line_length * staff_space' four times in the code
below

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123
mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space;
bot y1 = -foobar;
top y2 = foobar;
% see comment above

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133
mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space;
top y2 = foobar;
% see comment above

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140
mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space;
bot y3 = -foobar;
% see comment above

[Bertrand Bordage, 2011-09-13 13:27:44]

LGTM, with the same comment.

[janek, 2011-09-13 15:24:57]

New patch set uploaded.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120: 
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
> foobar = quanted_line_length * staff_space;
> % because you use 'quanted_line_length * staff_space' four times in the code
> below

Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123
mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
> bot y1 = -foobar;
> top y2 = foobar;
> % see comment above 

Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133
mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
> top y2 = foobar;
> % see comment above

Done.

http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140
mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
> bot y3 = -foobar;
> % see comment above

Done.

[Ian Hulin (gmail), 2011-09-13 16:44:56]

LGTM

Ian

[pkx166h, 2011-09-14 21:45:51]

passes make and reg tests - there are three reg tests that show up but nothing
significant.

See http://code.google.com/p/lilypond/issues/detail?id=1883#c1

[janek, 2011-09-17 21:21:11]

pushed as a2d8779a847dab1b6622da59be3a0e9247ff2ab2
thanks,
Janek