Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(76)

Issue 4961050: LWJGL macosx JAWT support for applets

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by pjoe
Modified:
9 years, 3 months ago
Reviewers:
mike.swingler
Base URL:
https://java-game-lib.svn.sourceforge.net/svnroot/java-game-lib/trunk/LWJGL/
Visibility:
Public.

Description

Get LWJGL applets working again on macosx, by using new CALayer model and pbuffer. See http://lwjgl.org/forum/index.php/topic,4023.0.html

Patch Set 1 #

Patch Set 2 : Cleaned up drawing of pbuffer, added checks for CALayer support #

Patch Set 3 : Set CALayer.opaque = YES #

Patch Set 4 : Use canDrawInGLContext, so pbuffer is only rendered when needed. Add check if Display.parent == null #

Patch Set 5 : Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build with 10.6 sdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -31 lines) Patch
platform_build/macosx_ant/build.xml View 1 2 3 4 4 chunks +18 lines, -15 lines 0 comments Download
src/java/org/lwjgl/opengl/AWTSurfaceLock.java View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
src/native/common/org_lwjgl_opengl_AWTSurfaceLock.c View 1 2 3 1 chunk +16 lines, -5 lines 0 comments Download
src/native/macosx/context.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
src/native/macosx/org_lwjgl_opengl_MacOSXCanvasPeerInfo.m View 1 2 3 4 2 chunks +144 lines, -5 lines 0 comments Download
src/native/macosx/org_lwjgl_opengl_MacOSXContextImplementation.m View 1 2 3 5 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6
pjoe
12 years, 7 months ago (2011-08-26 19:08:02 UTC) #1
pjoe
Cleaned up drawing of pbuffer, added checks for CALayer support
12 years, 7 months ago (2011-08-27 08:11:49 UTC) #2
pjoe
Set CALayer.opaque = YES
12 years, 7 months ago (2011-08-27 12:33:26 UTC) #3
pjoe
Use canDrawInGLContext, so pbuffer is only rendered when needed. Add check if Display.parent == null
12 years, 7 months ago (2011-08-27 18:05:46 UTC) #4
pjoe
Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build with 10.6 sdk
12 years, 7 months ago (2011-08-27 18:49:00 UTC) #5
mike.swingler
12 years, 7 months ago (2011-08-27 23:48:51 UTC) #6
On 2011/08/27 18:49:00, pjoe wrote:
> Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build
with
> 10.6 sdk

The implementation looks good to me - no (obvious) leaks, everything is being
done one the correct thread. Ship it!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b