Issue 4961050: LWJGL macosx JAWT support for applets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4961050: LWJGL macosx JAWT support for applets

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by pjoe

Modified:
9 years, 11 months ago

Reviewers:
mike.swingler

Base URL:
https://java-game-lib.svn.sourceforge.net/svnroot/java-game-lib/trunk/LWJGL/

Visibility:
Public.

Description

Get LWJGL applets working again on macosx, by using new CALayer model and pbuffer. See http://lwjgl.org/forum/index.php/topic,4023.0.html

Patch Set 1 #

Patch Set 2 : Cleaned up drawing of pbuffer, added checks for CALayer support #

Patch Set 3 : Set CALayer.opaque = YES #

Patch Set 4 : Use canDrawInGLContext, so pbuffer is only rendered when needed. Add check if Display.parent == null #

Patch Set 5 : Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build with 10.6 sdk #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -31 lines)			Patch
platform_build/macosx_ant/build.xml	View	1 2 3 4	4 chunks	+18 lines, -15 lines	0 comments	Download
src/java/org/lwjgl/opengl/AWTSurfaceLock.java	View	1 2 3 4	2 chunks	+5 lines, -4 lines	0 comments	Download
src/native/common/org_lwjgl_opengl_AWTSurfaceLock.c	View	1 2 3	1 chunk	+16 lines, -5 lines	0 comments	Download
src/native/macosx/context.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
src/native/macosx/org_lwjgl_opengl_MacOSXCanvasPeerInfo.m	View	1 2 3 4	2 chunks	+144 lines, -5 lines	0 comments	Download
src/native/macosx/org_lwjgl_opengl_MacOSXContextImplementation.m	View	1 2 3	5 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

pjoe

Cleaned up drawing of pbuffer, added checks for CALayer support

13 years, 3 months ago (2011-08-27 08:11:49 UTC) #2

pjoe

Use canDrawInGLContext, so pbuffer is only rendered when needed. Add check if Display.parent == null

13 years, 3 months ago (2011-08-27 18:05:46 UTC) #4

pjoe

Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build with 10.6 sdk

13 years, 3 months ago (2011-08-27 18:49:00 UTC) #5

mike.swingler

13 years, 3 months ago (2011-08-27 23:48:51 UTC) #6

On 2011/08/27 18:49:00, pjoe wrote:
> Check for AWTGLCanvas, rename RotatingSquareGLLayer > PBufferGLLayer, build
with
> 10.6 sdk

The implementation looks good to me - no (obvious) leaks, everything is being
done one the correct thread. Ship it!

Expand All Messages | Collapse All Messages