Issue 4960049: code review 4960049: plumb: character offsets start at 1, not 0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4960049: code review 4960049: plumb: character offsets start at 1, not 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

plumb: character offsets start at 1, not 0 x:10:1 is the beginning of line 10

Patch Set 1 #

Patch Set 2 : diff -r 0ab4cba756ea rsc/plan9port #

Patch Set 3 : diff -r 0ab4cba756ea rsc/plan9port #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	plumb/basic	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to rsc/plan9port

13 years, 4 months ago (2011-08-31 13:22:21 UTC) #1

rsc

13 years, 4 months ago (2011-08-31 13:22:28 UTC) #2

*** Submitted as 88e6f1663524 ***

plumb: character offsets start at 1, not 0

x:10:1 is the beginning of line 10

R=rsc
http://codereview.appspot.com/4960049

Expand All Messages | Collapse All Messages