Issue 4959044: code review 4959044: mime: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4959044: code review 4959044: mime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

mime: fix build The fix is to add ' ' after ';' so that we match what we used to generate. Packages like http look for the string with the space in it, and I don't see a reason to be so terse. Also s/buffer/b/

Patch Set 1 #

Patch Set 2 : diff -r fb948e74b80b https://go.googlecode.com/hg #

Patch Set 3 : diff -r fb948e74b80b https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -20 lines)			Patch
M	src/pkg/mime/mediatype.go	View	1	1 chunk	+15 lines, -14 lines	0 comments	Download
M	src/pkg/mime/type.go	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/mime/type_test.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-08-26 21:19:51 UTC) #1

rsc

13 years, 11 months ago (2011-08-26 21:19:55 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=bbf31358ad6e ***

mime: fix build

The fix is to add ' ' after ';' so that we match
what we used to generate.
Packages like http look for the string with
the space in it, and I don't see a reason to
be so terse.

Also s/buffer/b/

TBR=bradfitz
CC=golang-dev
http://codereview.appspot.com/4959044

Expand All Messages | Collapse All Messages