Issue 4958044: code review 4958044: build: fix unused parameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4958044: code review 4958044: build: fix unused parameters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsc

Modified:
13 years, 8 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

build: fix unused parameters Found with gcc 4.6 -Wunused -Wextra but should be applicable to Plan 9 too.

Patch Set 1 #

Patch Set 2 : diff -r 6577cd4b870f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6577cd4b870f https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -16 lines)			Patch
M	src/cmd/6g/gobj.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/cov/main.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/closure.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/cmd/godefs/main.c	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/cmd/gopack/ar.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/prof/main.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/lib9/exitcode.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/libmach/executable.c	View	1	6 chunks	+18 lines, -1 line	0 comments	Download
M	src/libmach/fakeobj.c	View	1	1 chunk	+14 lines, -14 lines	0 comments	Download
M	src/libmach/linux.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/libmach/map.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-25 20:08:07 UTC) #1

rsc

13 years, 8 months ago (2011-08-25 20:08:20 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=89b6b25f5e01 ***

build: fix unused parameters

Found with gcc 4.6 -Wunused -Wextra
but should be applicable to Plan 9 too.

R=ken2
CC=golang-dev
http://codereview.appspot.com/4958044

Expand All Messages | Collapse All Messages