Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3583)

Issue 4956062: Flush all ports after each file, flush stdout after displaying all options (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Reinhold
Modified:
12 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Flush all ports after each file, flush stdout after displaying all options So far, the output of the safe.ly regtest showed up randomly in some later regtest, because stdout was buffered when redirected to a file. This patch flushes all ports after each processed file (only relevant when multiple files are processed at once). Unfortunately, it seems stdout is not an open Scheme port when Scheme doesn't print anything to stdout. So, when displaying all options, we have to flush stdout directly after printing all options.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M lily/program-option-scheme.cc View 1 chunk +1 line, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
hanwenn
LGTM I think this may also fix log messages leaking between files in the regtest.
12 years, 7 months ago (2011-09-05 01:55:27 UTC) #1
pkx166h
Passes make and reg tests.
12 years, 7 months ago (2011-09-05 19:38:08 UTC) #2
Graham Percival (old account)
12 years, 7 months ago (2011-09-08 08:36:30 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b