Issue 4953049: code review 4953049: src/cmd/6g/*: Corrections according to Plan 9 tool chain.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4953049: code review 4953049: src/cmd/6g/*: Corrections according to Plan 9 tool chain. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by lucio

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

src/cmd/6g/*: Corrections according to Plan 9 tool chain. src/cmd/6g/cgen.c src/cmd/6g/gobj.c src/cmd/6g/reg.c . dropped unused assignments; src/cmd/6g/gg.h . added varargck pragmas; src/cmd/6g/list.c . adjusted print format for ulong casts; src/cmd/6g/peep.c . dropped redundant increment;

Patch Set 1 #

Patch Set 2 : diff -r 88744261dd47 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b982a9b23f2b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b982a9b23f2b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5e1053337103 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
M	src/cmd/6g/cgen.c	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/cmd/6g/gg.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6g/gobj.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6g/list.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6g/peep.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6g/reg.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-26 21:15:24 UTC) #1

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.

13 years, 8 months ago (2011-08-26 22:50:32 UTC) #3

lucio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.

13 years, 8 months ago (2011-08-27 16:47:20 UTC) #4

rsc

13 years, 8 months ago (2011-08-29 13:35:03 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=08d6736b1268 ***

6g: fix build on Plan 9

src/cmd/6g/cgen.c
src/cmd/6g/gobj.c
src/cmd/6g/reg.c
. dropped unused assignments;
src/cmd/6g/gg.h
. added varargck pragmas;
src/cmd/6g/list.c
. adjusted print format for ulong casts;
src/cmd/6g/peep.c
. dropped redundant increment;

R=golang-dev
CC=golang-dev, rsc
http://codereview.appspot.com/4953049

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages