Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 4952056: code review 4952056: re2: add logging of test cases, for Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by rsc
Modified:
12 years, 6 months ago
Reviewers:
CC:
r, re2-dev_googlegroups.com
Visibility:
Public.

Description

re2: add logging of test cases, for Go

Patch Set 1 #

Patch Set 2 : diff -r 7007b2180a42 https://re2.googlecode.com/hg/ #

Patch Set 3 : diff -r 7007b2180a42 https://re2.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a9f0eaee31d7 https://re2.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
M Makefile View 1 1 chunk +9 lines, -0 lines 0 comments Download
M re2/testing/exhaustive_tester.cc View 1 2 3 4 chunks +73 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg/
12 years, 6 months ago (2011-09-07 00:46:30 UTC) #1
r
LGTM except for indentation http://codereview.appspot.com/4952056/diff/3003/re2/testing/exhaustive_tester.cc File re2/testing/exhaustive_tester.cc (right): http://codereview.appspot.com/4952056/diff/3003/re2/testing/exhaustive_tester.cc#newcode60 re2/testing/exhaustive_tester.cc:60: return buf; these look like ...
12 years, 6 months ago (2011-09-07 00:49:58 UTC) #2
rsc
12 years, 6 months ago (2011-09-07 17:02:46 UTC) #3
*** Submitted as http://code.google.com/p/re2/source/detail?r=0c4897e8fbbc ***

re2: add logging of test cases, for Go

R=r
CC=re2-dev
http://codereview.appspot.com/4952056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b