Issue 4952050: code review 4952050: godoc: minor tweaks for app-engine use

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4952050: code review 4952050: godoc: minor tweaks for app-engine use (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by gri

Modified:
13 years, 11 months ago

Reviewers:

CC:
dsymonds, golang-dev

Visibility:
Public.

Description

godoc: minor tweaks for app-engine use - read search index files in groutine to avoid start-up failure on app engine because reading the files takes too long - permit usage of search index files and indexer - minor cosmetic cleanups

Patch Set 1 #

Patch Set 2 : diff -r f845253df880 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f845253df880 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cfa7b2e1dd91 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -45 lines)			Patch
M	src/cmd/godoc/appconfig.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/cmd/godoc/appinit.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View	1	4 chunks	+32 lines, -35 lines	0 comments	Download
M	src/cmd/godoc/main.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-09-01 23:38:31 UTC) #1

gri

13 years, 11 months ago (2011-09-02 17:07:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cc2d7633590e ***

godoc: minor tweaks for app-engine use

- read search index files in groutine to avoid
  start-up failure on app engine because reading
  the files takes too long
- permit usage of search index files and indexer
- minor cosmetic cleanups

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/4952050

Expand All Messages | Collapse All Messages