Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(537)

Issue 4952041: code review 4952041: gofix: forgot to rename the URL type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by r
Modified:
13 years, 8 months ago
Reviewers:
dsymonds
CC:
golang-dev, gri
Visibility:
Public.

Description

gofix: forgot to rename the URL type Fixes issue 2182

Patch Set 1 #

Patch Set 2 : diff -r 465b93bb273c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/cmd/gofix/url.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gofix/url_test.go View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-08-24 22:26:25 UTC) #1
gri
LGTM
13 years, 8 months ago (2011-08-24 22:31:11 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=c51a2f3f897a *** gofix: forgot to rename the URL type Fixes issue 2182 ...
13 years, 8 months ago (2011-08-25 00:16:23 UTC) #3
dsymonds
13 years, 8 months ago (2011-08-25 02:08:14 UTC) #4
LGTM

Golly. That was an obvious one we missed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b