Uses langdefs.py to create language list for create-weblinks-itexi.py

Patch 1 demonstrates how to import a library into a python file where the path is not already in the pathlist.  It half-fixes the issue where languages are defined in many places in make website - the other needs changes to website.make, but there is a problem with that since the variable PYTHON is not guaranteed to be defined.

Patch 2 should be read in conjuction with the change to the CG pushed as 022d5c7ef759c586e3ca6478cf5f1b5d56d31778.  This shows how to set PYTHONPATH as part of the call to make, to allow python to find included libraries.  Note the comment about the definition of the PYTHON variable.  This is defined in config.make.in which is called with a normal call to make website, but not with the out-of-build-tree version documented in the CG section as above.  Setting this as part of the call will be the next step.

Patch 5 should be the final version of this.  NB.  DO NOT USE THIS PATCH AS IS ON YOUR PRODUCTION SYSTEM.  I have set is with a reduced set of languages to prove it works.  Tested and working on make website.  Not yet tested on the standalone website build, but should work the same.

[PhilEHolmes, 2011-08-29 14:56:27]

As requested - please review.

[Graham Percival (old account), 2011-08-31 04:58:08]

http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-it...
File scripts/build/create-weblinks-itexi.py (right):

http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-it...
scripts/build/create-weblinks-itexi.py:31: # Unable to find langdefs
This looks more complicated than I was expecting, and I had a vague feeling that
I'd seen an easier way to do this.  Thankfully lilynet.net is now up, so I can
point out this:
  http://news.lilynet.net/spip.php?article115#paper_baggers

I never looked into it in any more depth, but evidently you can do something
special in website.make to let it find langdefs.

[PhilEHolmes, 2011-09-01 16:24:55]

An update after further research following GP's pointer.  Please review.

[Graham Percival (old account), 2011-09-01 20:51:18]

Looks plausible, but I haven't tested it quite yet.  Could we get:
1) update to the make-website.sh portion of the CG, line 249 of
website-work.itexi ?

2) define WEB_LANGS (or something similar) in langdefs.py, then use those in
create-weblinks.itexi.py ?

Once that's done, I'll give it a whirl, and then I think you can push it.

[janneke, 2011-09-02 06:25:59]

If that works, then why not have

--- a/scripts/build/create-weblinks-itexi.py
+++ b/scripts/build/create-weblinks-itexi.py
@@ -9,11 +9,11 @@ import sys
 import os
 import glob
 
 ### translation data -- shouldn't be here; see issue
 ### http://code.google.com/p/lilypond/issues/detail?id=1050
 
-#langs = ['', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'zh']
-langs = ['', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'zh']
+import langdefs
+langs = [i.code if i.code != 'en' else '' for i in langdefs.LANGUAGES]
 
 # Get/update node translations
 '''

[Graham Percival (old account), 2011-09-03 09:28:45]

On 2011/09/02 06:25:59, jan.nieuwenhuizen wrote:
> If that works, then why not have
> 
> +import langdefs
> +langs = [i.code if i.code != 'en' else '' for i in langdefs.LANGUAGES]

I agree.

Phil, why did you push this patch without implementing this, or at least
responding to Jan to say why you thought it was a bad idea?  I think this is bad
form; we want to encourage developers to review patches, but if we ignore their
suggestions that pretty much kills any incentive for people to review stuff.

Please revert the patch and let's talk about Jan's suggestion.

[mail_philholmes.net, 2011-09-03 09:36:33]

----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>; <jan.nieuwenhuizen@gmail.com>
Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Saturday, September 03, 2011 10:28 AM
Subject: Re: Uses langdefs.py to create language list 
forcreate-weblinks-itexi.py (issue 4951047)


> On 2011/09/02 06:25:59, jan.nieuwenhuizen wrote:
>> If that works, then why not have
>
>> +import langdefs
>> +langs = [i.code if i.code != 'en' else '' for i in
> langdefs.LANGUAGES]
>
> I agree.
>
> Phil, why did you push this patch without implementing this, or at least
> responding to Jan to say why you thought it was a bad idea?  I think
> this is bad form; we want to encourage developers to review patches, but
> if we ignore their suggestions that pretty much kills any incentive for
> people to review stuff.
>
> Please revert the patch and let's talk about Jan's suggestion.


Please see my previous email to you directly. I was trying to push a minor 
documentation change in another branch, and by mistake pushed this instead. 
I asked you to revert it because I don't know how.  If you let me know, I'll 
add it to my list of git commands.

I was waiting to get that sorted before responding to Jan.  My response is 
that I'm not very good at Python, and so was essentially writing Python in 
C-style.  Personally I find it easier to understand - I find a lot of the 
Python "short cuts" confusing style that probably add little in the way of 
performance, but I'm happy to change the line.

--
Phil Holmes

[Graham Percival, 2011-09-03 09:43:48]

On Sat, Sep 03, 2011 at 10:36:28AM +0100, Phil Holmes wrote:
> >Phil, why did you push this patch without implementing this, or at least
> >responding to Jan to say why you thought it was a bad idea?  I think
> 
> Please see my previous email to you directly.

ah, sorry.  I don't use percival.music.ca@ for email, so I didn't
see that message.
I've been meaning to switch my lilypond google account to graham@
for a while, but it never had high enough priority that I felt
good abandoning releases or regtests to actually get it done.

> I was trying to push a minor documentation change in another
> branch,

I see; I've done this before.  I think that
  git push
uploads stuff in all branches you have, but I'm not certain.  You
_might_ be about to avoid this by doing
  git push mybranch origin
or something like that, but I'm out of my depth here.


other emails will wait until the conference is over.

Cheers,
- Graham

[Graham Percival, 2011-09-04 12:39:22]

On Sat, Sep 03, 2011 at 10:36:28AM +0100, Phil Holmes wrote:
> Please see my previous email to you directly. I was trying to push a
> minor documentation change in another branch, and by mistake pushed
> this instead. I asked you to revert it because I don't know how.

ok, done.

> If you let me know, I'll add it to my list of git commands.

I think it's easy enough to google for this.

> I was waiting to get that sorted before responding to Jan.  My
> response is that I'm not very good at Python, and so was essentially
> writing Python in C-style.  Personally I find it easier to
> understand - I find a lot of the Python "short cuts" confusing style
> that probably add little in the way of performance, but I'm happy to
> change the line.

I know the feeling very well; to be honest, I'm still not
comforable with list comprehensions.  (that's the fancy term for
those [...blah...] things)

However, after a year of reading miscellaneous python tutorials /
idiomatic python sites / python optimization guides, I must admit
that everybody says they're worth getting use to (as well as being
faster!).  So I think it's best to bite the bullet and use them
more often -- especially since Jan kindly gave us exactly the line
we need.


Your CG patch about PYTHONHOME is slightly problematic.  It won't
work as printed on lilypond.org, because we don't follow the
recommended $HOME/lilypond-git thing there.  I think it would be
good to follow that advice, but I don't want to push something to
the CG that's wrong -- we have enough problems with the website
build as it is.  :(
This is only relevant in the "Graham is run over by a bus"
scenario, which I'm not planning on happening for at least the
next three months, but I'd still rather hold off on that.

Could you remind me to fix this on the server in a few days?  (or
maybe add an issue for it)

Cheers,
- Graham

[email_philholmes.net, 2011-09-04 14:53:53]

----- Original Message ----- 
From: "Graham Percival" <graham@percival-music.ca>
To: "Phil Holmes" <mail@philholmes.net>
Cc: <PhilEHolmes@googlemail.com>; <percival.music.ca@gmail.com>; 
<jan.nieuwenhuizen@gmail.com>; <lilypond-devel@gnu.org>; 
<reply@codereview.appspotmail.com>
Sent: Sunday, September 04, 2011 1:39 PM
Subject: Re: Uses langdefs.py to create language list 
forcreate-weblinks-itexi.py (issue 4951047)


> On Sat, Sep 03, 2011 at 10:36:28AM +0100, Phil Holmes wrote:
>> Please see my previous email to you directly. I was trying to push a
>> minor documentation change in another branch, and by mistake pushed
>> this instead. I asked you to revert it because I don't know how.
>
> ok, done.

Reading further on git, it appears to push all branches where the local 
branch matches the remote: so my commit in master was pushed to master, but 
my webbuild branch has no matching branch on master and so wasn't pushed.  I 
think I'd need to run git push -a webbuild:master to push just stuff from 
that local master.

>> If you let me know, I'll add it to my list of git commands.
>
> I think it's easy enough to google for this.

I'm working on the assumption that it's git revert and then either HEAD if 
you get there immediately, or use the commitish to ensure the correct commit 
is reverted.  I always prefer to check I've got the right syntax - see below 
for this as a problem with push....

>> I was waiting to get that sorted before responding to Jan.  My
>> response is that I'm not very good at Python, and so was essentially
>> writing Python in C-style.  Personally I find it easier to
>> understand - I find a lot of the Python "short cuts" confusing style
>> that probably add little in the way of performance, but I'm happy to
>> change the line.
>
> I know the feeling very well; to be honest, I'm still not
> comforable with list comprehensions.  (that's the fancy term for
> those [...blah...] things)
>
> However, after a year of reading miscellaneous python tutorials /
> idiomatic python sites / python optimization guides, I must admit
> that everybody says they're worth getting use to (as well as being
> faster!).  So I think it's best to bite the bullet and use them
> more often -- especially since Jan kindly gave us exactly the line
> we need.

No worries.  Willdo .

> Your CG patch about PYTHONHOME is slightly problematic.  It won't
> work as printed on lilypond.org, because we don't follow the
> recommended $HOME/lilypond-git thing there.  I think it would be
> good to follow that advice, but I don't want to push something to
> the CG that's wrong -- we have enough problems with the website
> build as it is.  :(
> This is only relevant in the "Graham is run over by a bus"
> scenario, which I'm not planning on happening for at least the
> next three months, but I'd still rather hold off on that.
>
> Could you remind me to fix this on the server in a few days?  (or
> maybe add an issue for it)

I'll add an issue:

http://code.google.com/p/lilypond/issues/detail?id=1864

--
Phil Holmes

[PhilEHolmes, 2011-09-04 15:22:20]

Updated patch to use Jan's syntax.  Please review.

[Graham Percival (old account), 2011-09-05 18:10:57]

LTGM, not tested, but I'm willing to put it up and just see if anything breaks.

My only qualm is that this takes lang.LANGAUGES, instead of defining a
WEB_LANGUAGES.  At the moment they're the same, but somebody might come in to do
a new translation, and we don't want to enable that on the website until it's
complete.
But I'm content to cross that bridge when we come to it.

[PhilEHolmes, 2011-09-14 16:35:31]

I hope the final version of the patch that removes language definitions from
website.make and uses langdefs.py for all language definition.

[Graham Percival (old account), 2011-09-14 19:49:54]

LGTM, go ahead and push.

[email_philholmes.net, 2011-09-15 09:54:37]

----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>; <jan.nieuwenhuizen@gmail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
Sent: Wednesday, September 14, 2011 8:49 PM
Subject: Re: Uses langdefs.py to create language list for 
create-weblinks-itexi.py (issue 4951047)


> LGTM, go ahead and push.
>
> http://codereview.appspot.com/4951047/

Pushed as a04d1cb5153717523cdafe23faeb2166571603da

--
Phil Holmes