Issue 4950052: code review 4950052: gc: fix div bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4950052: code review 4950052: gc: fix div bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by rsc

Modified:
13 years, 9 months ago

Reviewers:
brainman, ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: fix div bug

Patch Set 1 #

Patch Set 2 : diff -r b0b77de1d467 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bb1fee6d9f0f https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -10 lines)			Patch
M	src/cmd/6g/ggen.c	View	1	3 chunks	+17 lines, -6 lines	0 comments	Download
M	src/cmd/8g/ggen.c	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download
A	test/fixedbugs/bug366.go	View	1	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2011-08-30 12:47:27 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=fc60ef40030f *** gc: fix div bug R=ken2 CC=golang-dev http://codereview.appspot.com/4950052

13 years, 9 months ago (2011-08-30 12:47:37 UTC) #2

brainman

Fixed issue 2206? http://code.google.com/p/go/issues/detail?id=2206

13 years, 9 months ago (2011-08-30 23:29:35 UTC) #4

rsc

13 years, 9 months ago (2011-08-31 17:55:43 UTC) #5

On Tue, Aug 30, 2011 at 19:29,  <alex.brainman@gmail.com> wrote:
> Fixed issue 2206?

done, thanks

Expand All Messages | Collapse All Messages