Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4340)

Issue 4941041: Fix issue 11 -- beamlet points in wrong direction on tuplet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Carl
Modified:
12 years, 5 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix issue 11 -- beamlet points in wrong direction on tuplet

Patch Set 1 #

Patch Set 2 : Take care of subdivision #

Patch Set 3 : Fix subdivision problems #

Patch Set 4 : Fixed regtest to reflect good beaming #

Patch Set 5 : Fix typo in texidoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -61 lines) Patch
M input/regression/beam-multiplicity-over-rests.ly View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A input/regression/beamlet-point-toward-beat.ly View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A input/regression/beamlet-test.ly View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M lily/auto-beam-engraver.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M lily/beam-engraver.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M lily/beaming-pattern.cc View 1 2 6 chunks +127 lines, -51 lines 0 comments Download
M lily/include/beaming-pattern.hh View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13
Carl
I believe that this fixes issue 11. Please review. Thanks, Carl
12 years, 8 months ago (2011-08-20 23:20:47 UTC) #1
Carl
This patch breaks beam subdivision. Please wait to review until I fix the subdivision problem. ...
12 years, 8 months ago (2011-08-21 08:10:29 UTC) #2
Carl
I believe the subdivision issues are now fixed. Please review. Thanks, Carl
12 years, 8 months ago (2011-08-28 11:31:20 UTC) #3
pkx166h
Passes make and reg test shows one change see attached on http://code.google.com/p/lilypond/issues/detail?id=11#c14 probably expected.
12 years, 8 months ago (2011-08-30 21:18:15 UTC) #4
Carl
I believe this is now fixed and ready for testing. Thanks, Carl
12 years, 6 months ago (2011-10-30 14:54:53 UTC) #5
Carl
I believe this is now fixed and ready for testing. Thanks, Carl
12 years, 6 months ago (2011-10-30 14:54:53 UTC) #6
Carl
I believe this is now fixed and ready for testing. Thanks, Carl
12 years, 6 months ago (2011-10-30 14:54:55 UTC) #7
pkx166h
Passes make and make check gives one reg test diff attached on http://code.google.com/p/lilypond/issues/detail?id=11#c20 James
12 years, 5 months ago (2011-11-03 22:52:35 UTC) #8
Carl
New patchset uploaded
12 years, 5 months ago (2011-11-07 21:59:37 UTC) #9
pkx166h
Make passes but make check fails on \sourcefilename "/home/jlowe/lilypond-git/input/regression/beamlet-point-toward-beat.ly" \sourcefileline 0 \version "2.15.17" \header { ...
12 years, 5 months ago (2011-11-07 22:41:10 UTC) #10
Carl
New patch set
12 years, 5 months ago (2011-11-07 23:37:17 UTC) #11
pkx166h
Passes make, one reg test diff http://code.google.com/p/lilypond/issues/detail?id=11#c26 James
12 years, 5 months ago (2011-11-08 20:44:08 UTC) #12
pkx166h
12 years, 5 months ago (2011-11-09 20:57:24 UTC) #13
Carl,

I reran the patch again on a new build but still only got that one reg test show
up.

So running lilypond directly on the reg tests I have attached them here

http://code.google.com/p/lilypond/issues/detail?id=11#c31

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b