Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(258)

Issue 4940042: code review 4940042: template/parse: give if, range, and with a common repre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

template/parse: give if, range, and with a common representation. No external changes.

Patch Set 1 #

Patch Set 2 : diff -r d53529c96406 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 15cefddbe963 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -40 lines) Patch
M src/pkg/template/parse/node.go View 1 3 chunks +34 lines, -40 lines 0 comments Download

Messages

Total messages: 4
r
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-08-22 04:33:39 UTC) #1
r
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2011-08-22 04:36:11 UTC) #2
nigeltao
LGTM.
13 years, 11 months ago (2011-08-22 06:51:23 UTC) #3
r
13 years, 11 months ago (2011-08-22 07:09:10 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=e5d74f41daec ***

template/parse: give if, range, and with a common representation.
No external changes.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/4940042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b