Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 4939045: [pph] Remove fixed FIXME in p4eabi.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Gabriel Charette
Modified:
13 years, 8 months ago
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gcc/testsuite/g++.dg/pph/p4eabi1.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1
Gabriel Charette
13 years, 8 months ago (2011-08-23 18:08:29 UTC) #1
This memory problem was probably due to the big line_table being created with
the incorrect code before.

This test now passes and this FIXME was irrelevant, removed it.

Trivial patch, already discussed with Diego, committed to pph.

2011-08-23  Gabriel Charette  <gchare@google.com>

	* g++.dg/pph/p4eabi1.h: Remove fixed FIXME.

diff --git a/gcc/testsuite/g++.dg/pph/p4eabi1.h
b/gcc/testsuite/g++.dg/pph/p4eabi1.h
index 781de86..8c949ea 100644
--- a/gcc/testsuite/g++.dg/pph/p4eabi1.h
+++ b/gcc/testsuite/g++.dg/pph/p4eabi1.h
@@ -1,5 +1,4 @@
 // { dg-options "-w -fpermissive" }
-// FIXME pph - Enabling PPH for this file causes memory problems in cc1plus.
 // c1eabi1.h	c1eabi1.pph
 
 #ifndef C4EABI1_H

--
This patch is available for review at http://codereview.appspot.com/4939045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b