code review 4937048: misc/dashboard: remove limit for json package list

misc/dashboard: remove limit for json package list

[adg, 2011-08-23 07:47:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-08-23 08:10:28]

LGTM

On Tue, Aug 23, 2011 at 11:47 AM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> misc/dashboard: remove limit for json package list
>
> Please review this at
http://codereview.appspot.com/**4937048/<http://codereview.appspot.com/4937048/>
>
> Affected files:
>  M misc/dashboard/godashboard/**package.py
>
>
> Index: misc/dashboard/godashboard/**package.py
> ==============================**==============================**=======
> --- a/misc/dashboard/godashboard/**package.py
> +++ b/misc/dashboard/godashboard/**package.py
> @@ -211,7 +211,7 @@
>             q = Package.all()
>             s = '{"packages": ['
>             sep = ''
> -            for r in q.fetch(1000):
> +            for r in q:
>                 s += '%s\n\t{"path": "%s", "last_install": "%s", "count":
> "%s"}' % (sep, r.path, r.last_install, r.count)
>                 sep = ','
>             s += '\n]}\n'
>
>
>

[adg, 2011-08-23 23:52:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=a7d4f6cb5d87 ***

misc/dashboard: remove limit for json package list

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4937048