Issue 4936044: code review 4936044: ld: remove duplicate bss definitions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4936044: code review 4936044: ld: remove duplicate bss definitions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rsc

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

ld: remove duplicate bss definitions The EXTERN lines in elf.h already define these. That's not a problem for most C compilers, but apparently it is for some copies of the OS X linker. Fixes issue 2167.

Patch Set 1 #

Patch Set 2 : diff -r c62cf48b7dc4 https://go.googlecode.com/hg #

Patch Set 3 : diff -r c62cf48b7dc4 https://go.googlecode.com/hg #

Patch Set 4 : diff -r bb2e60a547e4 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/cmd/ld/symtab.c	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 10 months ago (2011-08-22 18:28:30 UTC) #1

iant

LGTM CL description refers to lib.h, which is where EXTERN is defined; the variables themselves ...

13 years, 10 months ago (2011-08-22 19:20:14 UTC) #2

rsc

13 years, 10 months ago (2011-08-23 03:24:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ae66a5b37ee9 ***

ld: remove duplicate bss definitions

The EXTERN lines in elf.h already define these.
That's not a problem for most C compilers, but
apparently it is for some copies of the OS X linker.

Fixes issue 2167.

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/4936044

Expand All Messages | Collapse All Messages