code review 4934049: os: use GetFileAttributesEx to implement Stat on windows

os: use GetFileAttributesEx to implement Stat on windows

Fixes issue 2129.

[brainman, 2011-08-24 12:06:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-08-24 14:33:40]

Do we have to worry about `.\` and `..\` and `\.` and `\..` and so on?

[brainman, 2011-09-05 07:10:42]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-09-05 12:14:21]

LGTM

http://codereview.appspot.com/4934049/diff/8001/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

http://codereview.appspot.com/4934049/diff/8001/src/pkg/os/file_windows.go#ne...
src/pkg/os/file_windows.go:67: r, e :=
syscall.FindFirstFile(syscall.StringToUTF16Ptr(name+"\\*"), &d.data)
while you're here, change "\\*" to `\*`

[brainman, 2011-09-05 23:59:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=2a748f320ba5 ***

os: use GetFileAttributesEx to implement Stat on windows

Fixes issue 2129.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4934049

http://codereview.appspot.com/4934049/diff/8001/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

http://codereview.appspot.com/4934049/diff/8001/src/pkg/os/file_windows.go#ne...
src/pkg/os/file_windows.go:67: r, e :=
syscall.FindFirstFile(syscall.StringToUTF16Ptr(name+"\\*"), &d.data)
On 2011/09/05 12:14:21, rsc wrote:
> while you're here, change "\\*" to `\*`

Done.