Issue 4930046: code review 4930046: runtime: fix void warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4930046: code review 4930046: runtime: fix void warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:
r, lucio

CC:
ken2, golang-dev

Visibility:
Public.

Description

runtime: fix void warnings Add -V flag to 6c command line to keep them fixed.

Patch Set 1 #

Patch Set 2 : diff -r d67e691bae3f https://go.googlecode.com/hg #

Patch Set 3 : diff -r 7052ad4cdc6a https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	src/pkg/runtime/Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/chan.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1	1 chunk	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-08-23 17:13:26 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=a7c390d2352d *** runtime: fix void warnings Add -V flag to 6c command ...

13 years, 11 months ago (2011-08-23 17:13:33 UTC) #2

rsc

On Tue, Aug 23, 2011 at 17:37, <r@golang.org> wrote: > where is the -V flag ...

13 years, 11 months ago (2011-08-23 21:38:58 UTC) #4

lucio

No -t? Is that going to cause any trouble? I haven't had any trouble under ...

13 years, 11 months ago (2011-08-24 05:04:22 UTC) #5

rsc

13 years, 11 months ago (2011-08-24 15:12:53 UTC) #6

On Wed, Aug 24, 2011 at 01:04, Lucio De Re <lucio.dere@gmail.com> wrote:
> No -t?  Is that going to cause any trouble?

much less worried about -t.
if everything includes the same headers
then there's no need for it.

Expand All Messages | Collapse All Messages