code review 4927046: go/ast: remove File/PackageExports functions.

go/ast cleanup: base File/PackageExports on FilterFile/FilterPackage code

[gri, 2011-08-23 02:46:04]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-23 03:13:31]

LGTM

[gri, 2011-08-23 21:26:43]

Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-08-23 21:37:55]

LGTM

But since the new functions are supposed to be
the same as the old ones, should they be renamed
to use the old names?  Then client code like godoc
and possibly programs written by external users
need not know about the internal cleanup.

[gri, 2011-08-23 22:38:14]

Yes. Possible now. Will rename and submit.
- gri

On Tue, Aug 23, 2011 at 2:37 PM,  <rsc@golang.org> wrote:
> LGTM
>
> But since the new functions are supposed to be
> the same as the old ones, should they be renamed
> to use the old names?  Then client code like godoc
> and possibly programs written by external users
> need not know about the internal cleanup.
>
>
> http://codereview.appspot.com/4927046/
>

[gri, 2011-08-23 23:03:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f64cba0d4a6 ***

go/ast cleanup: base File/PackageExports on FilterFile/FilterPackage code

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4927046