Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(751)

Issue 4923048: Fix memleak: temporary skyline objects for systems were never deleted (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Reinhold
Modified:
12 years, 7 months ago
Reviewers:
pkx166h, dan
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix memleak: temporary skyline objects for systems were never deleted

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M lily/skyline.cc View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Reinhold
This patch fixes a memleak: Some temporary skylines were never deleted... Please review
12 years, 7 months ago (2011-08-23 21:07:52 UTC) #1
pkx166h
passes make and reg tests
12 years, 7 months ago (2011-08-27 08:20:53 UTC) #2
dan_faithful.be
12 years, 7 months ago (2011-08-28 01:31:50 UTC) #3
On 2011-08-27, at 04:20 , pkx166h@gmail.com wrote:

> passes make and reg tests
> 
> http://codereview.appspot.com/4923048/


You could clean up Skyline::distance by pulling lines 532-548 into their own
function and letting Skyline::distance call it with different options:

if (horizon_padding != 0.0)
  {
    Skyline padded_this(. . .);
    Skyline padded_other(. . .);
    return unpadded_distance(padded_this, padded_other);
  }
else
  {
    return unpadded_distance(this, &other);
  }
-- 
Dan

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b