Issue 4923048: Fix memleak: temporary skyline objects for systems were never deleted

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4923048: Fix memleak: temporary skyline objects for systems were never deleted (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Reinhold

Modified:
13 years, 8 months ago

Reviewers:
pkx166h, dan

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix memleak: temporary skyline objects for systems were never deleted

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	lily/skyline.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Reinhold

This patch fixes a memleak: Some temporary skylines were never deleted... Please review

13 years, 8 months ago (2011-08-23 21:07:52 UTC) #1

dan_faithful.be

13 years, 8 months ago (2011-08-28 01:31:50 UTC) #3

On 2011-08-27, at 04:20 , pkx166h@gmail.com wrote:

> passes make and reg tests
> 
> http://codereview.appspot.com/4923048/


You could clean up Skyline::distance by pulling lines 532-548 into their own
function and letting Skyline::distance call it with different options:

if (horizon_padding != 0.0)
  {
    Skyline padded_this(. . .);
    Skyline padded_other(. . .);
    return unpadded_distance(padded_this, padded_other);
  }
else
  {
    return unpadded_distance(this, &other);
  }
-- 
Dan

Expand All Messages | Collapse All Messages