Issue 4922046: Fixes missing images in web-big-page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4922046: Fixes missing images in web-big-page (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by PhilEHolmes

Modified:
12 years, 8 months ago

Reviewers:
Graham Percival (old account)

Visibility:
Public.

Description

This patch works by adding an extra part (web/) to the path to the css link and the example images links, and then using postprocess_html.py to get rid of this for the split files. postprocess_html.py already makes this sort of change for a number of other aspects of split files. I have tested it on my local system and shown it working. Please note that there is an additional file in this patch - input/regression/musicxml/GNUmakefile - current master will not compile docs on my system without this change - Reinhold has debug information from me.

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	Documentation/lilypond-texi2html.init	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/macros.itexi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	input/regression/musicxml/GNUmakefile	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	python/auxiliar/postprocess_html.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

PhilEHolmes

Patch fixes the missing images in web-big-page.html. Please review.

12 years, 8 months ago (2011-08-22 16:53:22 UTC) #1

Graham Percival (old account)

This will have to wait until I'm in Glasgow to test it, sorry.

12 years, 8 months ago (2011-08-23 00:02:28 UTC) #2

PhilEHolmes

12 years, 8 months ago (2011-08-24 19:53:01 UTC) #3

I'm closing this review, because I've done more work and have an improved patch.
 I've also nuked lilypond-git, so closing this because it's out of date.

Expand All Messages | Collapse All Messages