Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10262)

Issue 4916041: Corrects image size in web.pdf - issue 982 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by PhilEHolmes
Modified:
12 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Corrects image size in web.pdf - issue 982 This patch updates all the macros.texi files to change the macro for exampleImage. It now uses an image with greater resolution and forces the width to 6 inches to fit onto the page. This is a first step towards making learning.pdf appear more professional.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Documentation/cs/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/nl/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/zh/macros.itexi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
PhilEHolmes
Please review this fairly simple change to improve the example images in learning.pdf
12 years, 8 months ago (2011-08-18 14:39:49 UTC) #1
Graham Percival (old account)
LGTM, but do we still use the -small images for anything else now? I mean, ...
12 years, 8 months ago (2011-08-19 10:40:50 UTC) #2
email_philholmes.net
12 years, 8 months ago (2011-08-19 10:43:24 UTC) #3
----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>; <percivall@gmail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
Sent: Friday, August 19, 2011 11:40 AM
Subject: Re: Corrects image size in web.pdf - issue 982 (issue 4916041)


> LGTM, but do we still use the -small images for anything else now?  I
> mean, go ahead and push this, but then please investigate if we still
> need the -small images, and if we don't need them, then please remove
> them from the build system.
>
> http://codereview.appspot.com/4916041/

[Address list snipped]

Yes - they're used in the web pages, with a link to the big ones that can be 
clicked to show more detail.

--
Phil Holmes


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b